London | 25-SDC-July | Andrei Filippov | Sprint 4 | Implement cowsay in Python#143
Open
Droid-An wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-July | Andrei Filippov | Sprint 4 | Implement cowsay in Python#143Droid-An wants to merge 2 commits intoCodeYourFuture:mainfrom
Droid-An wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Droid-An
added
📅 Sprint 4
DaryaShirokova
approved these changes
Aug 17, 2025
DaryaShirokova
left a comment
DaryaShirokova
left a comment
There was a problem hiding this comment.
LGTM, just some optional comments.
implement-cowsay/cow.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| import cowsay | |||
| import sys | |||
There was a problem hiding this comment.
I don't think sys and os are used?
implement-cowsay/cow.py
Outdated
|
|
||
| args = parser.parse_args() | ||
|
|
||
| print(cowsay.get_output_string(str(args.animal)," ".join(args.message))) No newline at end of file |
There was a problem hiding this comment.
You can format your code with ruff:
python3 -m pip install ruff
ruff format
ruff can also be added to requirements.txt, same way as cowsay.
DaryaShirokova
added
Complete
Author
|
Thank you for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
done cowsay
Questions
no questions